Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add missing tmpdir.refresh() in recently-added test #25098

Closed
wants to merge 1 commit into from
Closed

test: add missing tmpdir.refresh() in recently-added test #25098

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 17, 2018

Without tmpdir.refresh(), the test fails in some situations. This was
missed because using test.py will almost always result in a leftover
tmpdir lying around that makes the refresh() not needed.

Refs: #24913 (comment)

Collaborators, 👍 here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: add missing tmpdir.refresh() in recently-added test
4e3df0e 
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: nodejs#24913 (comment)
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 17, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1985/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 17, 2018
@Trott
Copy link
Member Author

Trott commented Dec 17, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19632/ ✔️

@targos
Copy link
Member

targos commented Dec 17, 2018 •
edited
Loading

Thanks. This fixes my case, which was git clean -fdx && ./configure && make test -j8 V=

@Trott
Copy link
Member Author

Trott commented Dec 18, 2018

Landed in 3ccb900

@Trott Trott closed this Dec 18, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 18, 2018
@Trott
test: add missing tmpdir.refresh() in recently-added test
3ccb900 
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: nodejs#24913 (comment)

PR-URL: nodejs#25098
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@Trott @MylesBorins
test: add missing tmpdir.refresh() in recently-added test
3e1fe19 
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: #24913 (comment)

PR-URL: #25098
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 25, 2018
Merged
@drewfish
Copy link
Contributor

Should the same changes also be made in test/parallel/test-child-process-spawnsync-args.js ?

refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: add missing tmpdir.refresh() in recently-added test
d79c469 
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: nodejs#24913 (comment)

PR-URL: nodejs#25098
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs pushed a commit that referenced this pull request Mar 14, 2019
@Trott @BethGriggs
test: add missing tmpdir.refresh() in recently-added test
38c9d2b 
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: #24913 (comment)

PR-URL: #25098
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the refresh2 branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@watilde watilde watilde approved these changes

@antsmartian antsmartian antsmartian approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @targos @drewfish @antsmartian @watilde @cjihrig @richardlau