Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win, build: fix building addons on Windows #25108

Closed
wants to merge 1 commit into from
Closed

win, build: fix building addons on Windows #25108

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Dec 18, 2018

Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@bzoz
win, build: fix building addons on Windows
64d5574 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: nodejs#25096
@nodejs-github-bot
Copy link
Collaborator

@bzoz build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1992/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Dec 18, 2018
@bzoz
Copy link
Contributor Author

bzoz commented Dec 18, 2018 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19656/ ✔️

@bzoz bzoz mentioned this pull request Dec 18, 2018
Closed
@bzoz
Copy link
Contributor Author

bzoz commented Dec 20, 2018

cc @nodejs/platform-windows @nodejs/build-files

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 20, 2018
@addaleax
Copy link
Member

Landed in 571273a

@addaleax addaleax closed this Dec 31, 2018
addaleax pushed a commit that referenced this pull request Dec 31, 2018
@bzoz @addaleax
win, build: fix building addons on Windows
571273a 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Jan 1, 2019
@bzoz @targos
win, build: fix building addons on Windows
2df0d14 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@bzoz @refack
win, build: fix building addons on Windows
f23139f 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: nodejs#25096

PR-URL: nodejs#25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@bzoz @BethGriggs
win, build: fix building addons on Windows
9af9ee5 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@bzoz @BethGriggs
win, build: fix building addons on Windows
979a397 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@bzoz @MylesBorins
win, build: fix building addons on Windows
91c4d28 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure on Windows
4 participants
@bzoz @nodejs-github-bot @addaleax @BridgeAR