[10.x] test: fix expectation in test-bootstrap-modules #25112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofrobots
changed the title
2 tasks
MylesBorins
approved these changes
Dec 19, 2018
codebytere
approved these changes
Dec 19, 2018
|
@nodejs/backporters this is ready to land. |
codebytere
pushed a commit
that referenced
this pull request
Dec 21, 2018
PR-URL: #25112 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
|
landed in |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2018
PR-URL: #25112 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 22, 2018
PR-URL: #25112 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 22, 2018
PR-URL: #25112 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 25, 2018
PR-URL: #25112 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This was referenced Dec 26, 2018
MylesBorins
added a commit
to MylesBorins/node
that referenced
this pull request
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #25027 (comment)
CI:
https://ci.nodejs.org/job/node-test-pull-request/19661/https://ci.nodejs.org/job/node-test-pull-request/19700/Lint rerun: https://ci.nodejs.org/job/node-test-linter/24472/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes