Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for http request set timeout #25121

Closed
wants to merge 1 commit into from
Closed

Update docs for http request set timeout #25121

wants to merge 1 commit into from

Conversation

jbunton-atlassian
Copy link
Contributor

@jbunton-atlassian jbunton-atlassian commented Dec 19, 2018 •
edited
Loading

When upgrading from Node.js 8 to 10 I hit the behaviour change in #8895. This documentation update would have helped me find the problem faster :)

Also see #25123 for an update to the v8.x docs.

Thanks :)

Checklist

@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Dec 19, 2018
@jbunton-atlassian jbunton-atlassian mentioned this pull request Dec 19, 2018
Closed
2 tasks
@mscdex
Copy link
Contributor

mscdex commented Dec 19, 2018

I'm confused. This PR currently contains more than a documentation change.

@jbunton-atlassian jbunton-atlassian force-pushed the update_docs_for_http_request_setTimeout branch from ed4ac0d to 84cd47b Compare December 19, 2018 04:52
@jbunton-atlassian
Copy link
Contributor Author

@mscdex, sorry again! I created these doc commits from a branch where I'm trying to track down another problem.

I've rebased to exclude the non-doc change.

@jbunton-atlassian jbunton-atlassian mentioned this pull request Dec 19, 2018
Closed
2 tasks
lpinca
lpinca reviewed Dec 19, 2018
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
@lpinca lpinca added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. and removed child_process Issues and PRs related to the child_process subsystem. labels Dec 19, 2018
@jbunton-atlassian jbunton-atlassian force-pushed the update_docs_for_http_request_setTimeout branch from 84cd47b to 2b4d26a Compare December 19, 2018 07:30
@jbunton-atlassian
Copy link
Contributor Author

Thanks @lpinca :)

@jbunton-atlassian jbunton-atlassian force-pushed the update_docs_for_http_request_setTimeout branch 2 times, most recently from 84cd47b to 2b4d26a Compare December 19, 2018 12:48
vsemozhetbyt
vsemozhetbyt reviewed Dec 19, 2018
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
@jbunton-atlassian jbunton-atlassian force-pushed the update_docs_for_http_request_setTimeout branch from 2b4d26a to 5708c6a Compare December 19, 2018 21:51
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2012/

@jbunton-atlassian
Copy link
Contributor Author

Hi there, could somebody please merge this for me? Thanks!

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2019
@vsemozhetbyt
Copy link
Contributor

Landed in b83088b
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Jan 9, 2019
@jbunton-atlassian @vsemozhetbyt
doc: add history to http.request.setTimeout()
b83088b 
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@jbunton-atlassian @addaleax
doc: add history to http.request.setTimeout()
8380bd4 
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@jbunton-atlassian @BridgeAR
doc: add history to http.request.setTimeout()
ddaf69c 
PR-URL: nodejs#25121
Refs: nodejs#8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@jbunton-atlassian @BethGriggs
doc: add history to http.request.setTimeout()
abacd1e 
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@jbunton-atlassian @BethGriggs
doc: add history to http.request.setTimeout()
7964746 
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@jbunton-atlassian @MylesBorins
doc: add history to http.request.setTimeout()
487f653 
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jbunton-atlassian @mscdex @vsemozhetbyt @jasnell @addaleax @lpinca @nodejs-github-bot