Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: fix crash for invalid index types #25154

Closed
wants to merge 1 commit into from
Closed

buffer: fix crash for invalid index types #25154

wants to merge 1 commit into from

Commits on Dec 20, 2018

  1. buffer: fix crash for invalid index types 

    2555cb4 introduced a crash
when a non-number value was passed to `ParseArrayIndex()`.

We do not always have JS typechecking for that in place, though.
This returns back to the previous behavior of coercing values
to integers, which is certainly questionable.

Refs: nodejs#22129
Fixes: nodejs#23668
    @addaleax
    addaleax committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    76a81ba View commit details
    Browse the repository at this point in the history