Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: remove use less internalFS #25161

Closed
wants to merge 1 commit into from
Closed

fs: remove use less internalFS #25161

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 21, 2018

internalFS is just used once in the whole fs.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Dec 21, 2018
@lpinca
Copy link
Member

lpinca commented Feb 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20689/

@lpinca
Copy link
Member

lpinca commented Feb 9, 2019

Landed in 3681ddd.

@lpinca lpinca closed this Feb 9, 2019
pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Feb 9, 2019
@ZYSzys @lpinca
fs: remove useless internalFS
3681ddd 
PR-URL: nodejs#25161
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ZYSzys ZYSzys deleted the fs-remove-use-less-internal-fs branch February 10, 2019 06:46
targos pushed a commit that referenced this pull request Feb 10, 2019
@ZYSzys @targos
fs: remove useless internalFS
29c195e 
PR-URL: #25161
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZYSzys @lpinca @jasnell @targos @cjihrig @tniessen @nodejs-github-bot