test: remove Files: comment processing from Python test runner #25183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use any Files: comments in our tests so remove the Python code for it from test/testpy/__init__.py.
richardlau
approved these changes
Dec 22, 2018
targos
approved these changes
Dec 22, 2018
Trott
added
the
author ready
lpinca
approved these changes
Dec 22, 2018
trivikr
approved these changes
Dec 23, 2018
|
Landed in bcea74f |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 23, 2018
We don't use any Files: comments in our tests so remove the Python code for it from test/testpy/__init__.py. PR-URL: nodejs#25183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Argh, I misread "PM" for "AM" and landed this 12 hours early. Sorry. Since there aren't a lot of commits landing right around now, reverting this shouldn't be a big deal if anyone has issues with it. It's a small and easy-to-reverse change. Sorry about the error. (I also mis-read 9:54 as 9:45 but that's a smaller problem.) |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 25, 2018
We don't use any Files: comments in our tests so remove the Python code for it from test/testpy/__init__.py. PR-URL: #25183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
We don't use any Files: comments in our tests so remove the Python code for it from test/testpy/__init__.py. PR-URL: #25183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
We don't use any Files: comments in our tests so remove the Python code for it from test/testpy/__init__.py. PR-URL: nodejs#25183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 17, 2019
We don't use any Files: comments in our tests so remove the Python code for it from test/testpy/__init__.py. PR-URL: #25183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
We don't use any Files: comments in our tests so remove the Python code for it from test/testpy/__init__.py. PR-URL: #25183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
We don't use any Files: comments in our tests so remove the Python code for it from test/testpy/__init__.py. PR-URL: #25183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
We don't use any Files: comments in our tests so remove the Python code for it from test/testpy/__init__.py. PR-URL: #25183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use any Files: comments in our tests so remove the Python code
for it from test/testpy/init.py.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes