Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: Fix workers isolation #25196

Closed
wants to merge 12 commits into from

Commits on Dec 14, 2018

  1. lib: http2 compatibility error with connection header

    Ignoring the connection header and disable the
    `ERR_HTTP2_INVALID_CONNECTION_HEADERS` error.
    
    Added a warning log on the compatibility.
    
    Fixes: nodejs#23748
    sagitsofan committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    685d968 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2018

  1. test: mark test-worker-memory flaky on Windows CI

    Refs: nodejs#23277
    
    PR-URL: nodejs#25042
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Trott authored and sagitsofan committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    52a54c4 View commit details
    Browse the repository at this point in the history
  2. test: remove reference to whatwg in file names under test/wpt

    WPT covers standards in both W3C and WHATWG, as such it would be
    strange to make this disparity explicit in our file names
    (e.g. when testing standards that are solely in W3C, like
    performance-timeline). Remove the reference to WHATWG will
    also make the file names shorter.
    
    PR-URL: nodejs#24826
    Refs: nodejs#24823
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    joyeecheung authored and sagitsofan committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    0fcd047 View commit details
    Browse the repository at this point in the history
  3. test: improve WPT runner name matching

    This patch:
    
    - Support wildcards(*) in WPT runner name matching (needed by e.g.
      encoding where all the tests requires i18n support in the build)
    - Print failure reasons when encountering an expected failure
    - Fix a bug in copyGlobalsFromObject (previously it copies
      properties from `global` instead of the given `obj`)
    
    Previously an expected failure is printed as
    
    ```
    [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
    ```
    
    Now it is printed as
    
    ```
    [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
    missing Request and Response
    ```
    
    PR-URL: nodejs#24826
    Refs: nodejs#24823
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    joyeecheung authored and sagitsofan committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    ceafd58 View commit details
    Browse the repository at this point in the history
  4. test: mark test-child-process-exit-code flaky

    Refs: # nodejs#25033
    
    PR-URL: nodejs#25050
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Trott authored and sagitsofan committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    617ecdb View commit details
    Browse the repository at this point in the history
  5. test: mark test-child-process-execfile flaky

    Refs: nodejs#25029
    
    PR-URL: nodejs#25051
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Trott authored and sagitsofan committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    b657f75 View commit details
    Browse the repository at this point in the history
  6. lib: remove internalBinding('config').pendingDeprecation

    Instead use
    `require('internal/options').getOptionValue('--pending-deprecation')`
    
    PR-URL: nodejs#24962
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joyeecheung authored and sagitsofan committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    b3e8d37 View commit details
    Browse the repository at this point in the history
  7. util: remove todo

    Most people are going to use the existing option and switching the
    name now comes with a cost which does not seem to justify the
    improvement.
    
    PR-URL: nodejs#24982
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    BridgeAR authored and sagitsofan committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    0a3b88f View commit details
    Browse the repository at this point in the history
  8. test: adding history regression test case

    PR-URL: nodejs#24843
    Refs: nodejs#24385
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    antsmartian authored and sagitsofan committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    6061d24 View commit details
    Browse the repository at this point in the history
  9. minor fix

    sagitsofan committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    df68413 View commit details
    Browse the repository at this point in the history
  10. lib: worker fix workers isolation

    Added strict mode inside the worker script.
    
    Fixes: nodejs#24947
    sagitsofan committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    f34f390 View commit details
    Browse the repository at this point in the history
  11. change const

    sagitsofan committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    3302221 View commit details
    Browse the repository at this point in the history