lib: worker fix workers isolation

[sagitsofan]

lib: fix workers isolation

Added strict mode inside the worker script.

Fixes: #24947

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[tshemsedinov]

That's not good practice to duplicate PRs. Instead of closing #25196 it would be better to rebase it. New PR contains 3 commits including merge commit and you need to delete merge commit and squash everything to a single commit. If you have problems with rebase, other contributors can help you but don't open new PR. I am not sure you need to reopen and rebase previous PR or rebase this one. @lundibundi can you please help us?

[Trott]

To keep things moving, I rebased and force pushed to the branch.

(If it helps anywone for the future, I used git rebase -i upstream/master and used fixup on all commits but the first one to squash everything into the fist commit. Then I use git push --force-with-lease to push the branch back up to @sagitsofan's remote/branch, updating the PR.)

Before the force push, I ran git commit --amend to edit the commit message slightly to more strictly comply with our commit message requirements. (It was OK the way it was, but the subsystem can be narrower and the first word after the subsystem is preferred to be an imperative verb. These are no big deal, but I figured while I was there, I might as well tidy that up too.)

[sagitsofan]

@Trott @tshemsedinov Thanks, i will pay attention for next time.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/19790/

[devsnek]

This doesn't actually fix the issue, and will probably break people who are expecting to use sloppy mode.

[Trott]

Needs a test.

[sagitsofan]

So i made some more tests and it seems that the strict mode is really not fixing the issue.
Should the appropriate solution needs to be a regex search on the input script or some other solution?

[devsnek]

@sagitsofan the setter and deleter need to be conditionally installed depending on if its being run in the main thread or worker thread.

node/src/node_env_var.cc

Lines 208 to 209 in 77db1e7

	env_proxy_template->SetHandler(NamedPropertyHandlerConfiguration(
	EnvGetter, EnvSetter, EnvQuery, EnvDeleter, EnvEnumerator, data));

[sagitsofan]

the setter and deleter need to be conditionally installed depending on if its being run in the main thread or worker thread.
@devsnek
Should the check of the main thread needs to be under worker.js or node_env_var.cc?

[addaleax]

I don’t think this PR will end up being merged, so I’ll close this out. Sorry, and thanks for the PR!