Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: more tests for internal/util/types #25225

Closed
wants to merge 2 commits into from
Closed

test: more tests for internal/util/types #25225

wants to merge 2 commits into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 26, 2018 •
edited
Loading

Add more tests for methods in internal/util/types.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 26, 2018
@addaleax
Copy link
Member

addaleax commented Jan 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/19980/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 7, 2019
mhdawson
mhdawson approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax
Copy link
Member

addaleax commented Jan 9, 2019

Landed in 519a11b

@addaleax addaleax closed this Jan 9, 2019
addaleax pushed a commit that referenced this pull request Jan 9, 2019
@ZYSzys @addaleax
test: more tests for internal/util/types
519a11b 
PR-URL: #25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax pushed a commit that referenced this pull request Jan 9, 2019
@ZYSzys @addaleax
test: more tests for internal/util/types
fc22df9 
PR-URL: #25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@ZYSzys @BridgeAR
test: more tests for internal/util/types
75efebb 
PR-URL: nodejs#25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@ZYSzys ZYSzys deleted the test-util-types branch January 18, 2019 18:03
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@ZYSzys @BethGriggs
test: more tests for internal/util/types
8707290 
PR-URL: #25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@ZYSzys @BethGriggs
test: more tests for internal/util/types
69568a0 
PR-URL: #25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@ZYSzys @MylesBorins
test: more tests for internal/util/types
c103e98 
PR-URL: #25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@mhdawson mhdawson mhdawson approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZYSzys @addaleax @jasnell @mhdawson @juanarbol @nodejs-github-bot