Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix zero byte allocation assertion failure #25248

Closed
wants to merge 2 commits into from
Closed

crypto: fix zero byte allocation assertion failure #25248

wants to merge 2 commits into from

Commits on Dec 28, 2018

  1. crypto: fix zero byte allocation assertion failure 

    When an empty string was passed, malloc might have returned a nullptr
depending on the platform, causing an assertion failure. This change
makes private key parsing behave as public key parsing does, causing
a BIO error instead that can be caught in JS.

Fixes: nodejs#25247
    @tniessen
    tniessen committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    ab862e8 View commit details
    Browse the repository at this point in the history

  2. fixup! crypto: fix zero byte allocation assertion failure

    @tniessen
    tniessen committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    3c5b00a View commit details
    Browse the repository at this point in the history