Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 56f6a76 #25269

Closed
wants to merge 1 commit into from

Commits on Dec 29, 2018

  1. deps: V8: cherry-pick 56f6a76

    Original commit message:
    
        [turbofan] Fix -0 check for subnormals.
    
        Previously we'd check `x` for -0 by testing `(1.0 / x) == -Infinity`,
        but this will yield the wrong results when `x` is a subnormal, i.e.
        really close to 0.
    
        In CSA we already perform bit checks to test for -0, so teach TurboFan
        to do the same for comparisons to -0 (via `Object.is`). We introduce a
        new NumberIsMinusZero simplified operator to handle the case where
        SimplifiedLowering already knows that the input is a number.
    
        Bug: chromium:903043, v8:6882
        Change-Id: I0cb7c568029b461a92fc183104d5f359b4bfe7f4
        Reviewed-on: https://chromium-review.googlesource.com/c/1328802
        Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
        Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#57382}
    
    Refs: v8/v8@56f6a76
    BridgeAR committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    968a707 View commit details
    Browse the repository at this point in the history