Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix net-wrap-js-stream-passthrough #25273

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 29, 2018

The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

👍 here to fast-track. This fixes node-daily-master Jenkins job. (The benchmark tests are only run there.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 29, 2018
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. net Issues and PRs related to the net subsystem. labels Dec 29, 2018
@Trott
Copy link
Member Author

Trott commented Dec 29, 2018

Benchmark tests aren't run in CI so Lite CI seems sufficient (as it will lint the change at least).

@Trott
Copy link
Member Author

Trott commented Dec 29, 2018

Landed in 903630e

@Trott Trott closed this Dec 29, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 29, 2018
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: nodejs#25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Jan 1, 2019
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: #25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: nodejs#25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: #25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: #25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
BethGriggs pushed a commit that referenced this pull request May 10, 2019
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: #25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
The net-wrap-js-stream-passthrough benchmark was inadvertently broken by
00944c7. This fixes it.

PR-URL: #25273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott deleted the fix-benchmark branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. fast-track PRs that do not need to wait for 48 hours to land. net Issues and PRs related to the net subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants