Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-util-callbackify flaky on AIX #25284

Closed
wants to merge 1 commit into from
Closed

test: mark test-util-callbackify flaky on AIX #25284

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 30, 2018

Refs: #25068

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Dec 30, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2112/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 30, 2018
@Trott
Copy link
Member Author

Trott commented Dec 30, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19866/ ✅

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 31, 2018
@Trott
Copy link
Member Author

Trott commented Jan 2, 2019

Landed in 5fab50b

@Trott Trott closed this Jan 2, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 2, 2019
@Trott
test: mark test-util-callbackify flaky on AIX
5fab50b 
Refs: nodejs#25068

PR-URL: nodejs#25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 5, 2019
@Trott @addaleax
test: mark test-util-callbackify flaky on AIX
61fc3bf 
Refs: #25068

PR-URL: #25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: mark test-util-callbackify flaky on AIX
fddd07f 
Refs: nodejs#25068

PR-URL: nodejs#25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@Trott @BridgeAR
test: mark test-util-callbackify flaky on AIX
477185c 
Refs: nodejs#25068

PR-URL: nodejs#25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@Trott @BethGriggs
test: mark test-util-callbackify flaky on AIX
07724fe 
Refs: #25068

PR-URL: #25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@Trott @BethGriggs
test: mark test-util-callbackify flaky on AIX
2987c96 
Refs: #25068

PR-URL: #25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@Trott @MylesBorins
test: mark test-util-callbackify flaky on AIX
5095d6c 
Refs: #25068

PR-URL: #25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the flaky-callbackify branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @jasnell @lpinca @cjihrig