Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: improve JS Array creation from C++ #25288

Closed
wants to merge 2 commits into from
Closed

src: improve JS Array creation from C++ #25288

wants to merge 2 commits into from

Commits on Dec 31, 2018

  1. src: improve ToV8Value() functions 

    - Cache the `isolate` value between calls
- Introduce an overload for dealing with integers/numbers
- Use the vectored `v8::Array::New` constructor + `MaybeStackBuffer`
  for faster array creation
    @addaleax
    addaleax committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    3aa3248 View commit details
    Browse the repository at this point in the history

  2. src: simplify JS Array creation 

    Use `ToV8Value()` where appropriate to reduce duplication
and avoid extra `Array::Set()` calls.
    @addaleax
    addaleax committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    1e3897b View commit details
    Browse the repository at this point in the history