Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix and refactor test-fs-watch-non-recursive #25386

Closed
wants to merge 2 commits into from
Closed

test: fix and refactor test-fs-watch-non-recursive #25386

wants to merge 2 commits into from

Commits on Jan 8, 2019

  1. test: fix test/pummel/test-fs-watch-non-recursive.js 

    test-fs-watch-non-recursive was loading the `common/tmpdir` module as if
it were a built-in and was failing because of it. Fix the path. The test
now works.
    @Trott
    Trott committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    2daeff0 View commit details
    Browse the repository at this point in the history

  2. test: refactor test-fs-watch-non-recursive 

    The test was duplicating some functionality in the `tmpdir` module.
    @Trott
    Trott committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    bcd34ac View commit details
    Browse the repository at this point in the history