build: add check for empty openssl-fips flag #25391
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
Currently, when specifying the --openssl-fips flag without any path , or an empty path, does not generate an error. If a path is specified then the following error is generated: ERROR: FIPS is not supported in this version of Node.js This commit adds a check so that the error is generated even if the path is empty.
richardlau
approved these changes
Jan 8, 2019
jasnell
approved these changes
Jan 8, 2019
lpinca
approved these changes
Jan 8, 2019
BridgeAR
approved these changes
Jan 10, 2019
|
Landed in f9b129e. |
danbev
added a commit
that referenced
this pull request
Jan 11, 2019
Currently, when specifying the --openssl-fips flag without any path , or an empty path, does not generate an error. If a path is specified then the following error is generated: ERROR: FIPS is not supported in this version of Node.js This commit adds a check so that the error is generated even if the path is empty. PR-URL: #25391 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Jan 14, 2019
Currently, when specifying the --openssl-fips flag without any path , or an empty path, does not generate an error. If a path is specified then the following error is generated: ERROR: FIPS is not supported in this version of Node.js This commit adds a check so that the error is generated even if the path is empty. PR-URL: #25391 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
Currently, when specifying the --openssl-fips flag without any path , or an empty path, does not generate an error. If a path is specified then the following error is generated: ERROR: FIPS is not supported in this version of Node.js This commit adds a check so that the error is generated even if the path is empty. PR-URL: nodejs#25391 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
Currently, when specifying the --openssl-fips flag without any path , or an empty path, does not generate an error. If a path is specified then the following error is generated: ERROR: FIPS is not supported in this version of Node.js This commit adds a check so that the error is generated even if the path is empty. PR-URL: #25391 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
Currently, when specifying the --openssl-fips flag without any path , or an empty path, does not generate an error. If a path is specified then the following error is generated: ERROR: FIPS is not supported in this version of Node.js This commit adds a check so that the error is generated even if the path is empty. PR-URL: #25391 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
Currently, when specifying the --openssl-fips flag without any path , or an empty path, does not generate an error. If a path is specified then the following error is generated: ERROR: FIPS is not supported in this version of Node.js This commit adds a check so that the error is generated even if the path is empty. PR-URL: #25391 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when specifying the
--openssl-fipsflag without any path, or an empty path, does not generate an error. If a path is specified
then the following error is generated:
ERROR: FIPS is not supported in this version of Node.jsThis commit adds a check so that the error is generated even if the
path is empty.
@nodejs/build-files
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes