Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x] backport #25087, #24962, #24931 and #25006 #25405

Closed
wants to merge 4 commits into from
Closed

[v11.x] backport #25087, #24962, #24931 and #25006 #25405

wants to merge 4 commits into from

Commits on Jan 9, 2019

  1. os: move process.binding('os') to internalBinding 

    PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @briete @BridgeAR
    briete authored and BridgeAR committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    09f844a View commit details
    Browse the repository at this point in the history

  2. lib: remove internalBinding('config').pendingDeprecation 

    Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`

PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @joyeecheung @BridgeAR
    joyeecheung authored and BridgeAR committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    57a5b97 View commit details
    Browse the repository at this point in the history

  3. inspector: move process.binding to internalBinding 

    In places of process.binding('inspector'), migrate code to adapt
internalBinding.

PR-URL: nodejs#24931
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @BeniCheni @BridgeAR
    BeniCheni authored and BridgeAR committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    40df84f View commit details
    Browse the repository at this point in the history

  4. util: inspect ArrayBuffers contents as well 

    Inspecting an ArrayBuffer now also shows their binary contents.

PR-URL: nodejs#25006
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @BridgeAR
    BridgeAR committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    7472860 View commit details
    Browse the repository at this point in the history