docs: document that stream.on('close') was changed in Node 10. #25413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
cc @mafintosh |
richardlau
approved these changes
Jan 9, 2019
sam-github
reviewed
Jan 9, 2019
jasnell
approved these changes
Jan 9, 2019
sam-github
added a commit
to sam-github/node
that referenced
this pull request
Jan 9, 2019
stream.md was the only YAML in doc/api that was using `>` for line continuation, and only used it for a few descriptions, most used the same wrapping style the rest of the documentation does. Also added punctuation and capitialization to a few description sentences. Fixes: nodejs#25413 (comment)
3 tasks
|
@sam-github do you prefer this to rebase on top of #25419? |
vsemozhetbyt
reviewed
Jan 9, 2019
vsemozhetbyt
reviewed
Jan 9, 2019
|
No I mean, you land that, and then I amend this one? Or the contrary? |
|
Actually, #25419 was fast-tracked so I guess rebasing this one would be the way to go. Sorry, I process github notifications sequentially! |
|
And it landed (I'm sure you'll notice). |
|
Reopening this one because it was closed by github. |
BridgeAR
approved these changes
Jan 10, 2019
mcollina
force-pushed
the
close-event-stream
branch
from
93d579b
to
401ca19
Compare
|
@sam-github @vsemozhetbyt check it out! |
sam-github
approved these changes
Jan 10, 2019
|
Landed in 18d3aeb |
addaleax
pushed a commit
that referenced
this pull request
Jan 14, 2019
stream.md was the only YAML in doc/api that was using `>` for line continuation, and only used it for a few descriptions, most used the same wrapping style the rest of the documentation does. Also added punctuation and capitialization to a few description sentences. Fixes: #25413 (comment) PR-URL: #25419 Fixes: #25413 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
stream.md was the only YAML in doc/api that was using `>` for line continuation, and only used it for a few descriptions, most used the same wrapping style the rest of the documentation does. Also added punctuation and capitialization to a few description sentences. Fixes: nodejs#25413 (comment) PR-URL: nodejs#25419 Fixes: nodejs#25413 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
See: nodejs#25373 See: nodejs#18438 PR-URL: nodejs#25413 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
Merged
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #25373
See: #18438
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes