Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve code coverage for i18n #25428

Closed
wants to merge 1 commit into from
Closed

test: improve code coverage for i18n #25428

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

Coverage report for src/node_i18n.cc shows that the
Has() method is not covered. This test adds coverage
for that method.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mhdawson
test: improve code coverage for i18n
d07ed5a 
Coverage report for src/node_i18n.cc shows that the
Has() method is not covered. This test adds coverage
for that method.
@nodejs-github-bot
Copy link
Collaborator

@mhdawson build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2217/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 10, 2019
@mhdawson mhdawson added the coverage Issues and PRs related to native coverage support. label Jan 10, 2019
@mhdawson mhdawson requested a review from jasnell January 10, 2019 03:54
@mhdawson
Copy link
Member Author

CI run: https://ci.nodejs.org/job/node-test-pull-request/

@mhdawson
Copy link
Member Author

CI was good, will land.

@mhdawson
Copy link
Member Author

Well new CI since I may not had the right link for the last one: https://ci.nodejs.org/job/node-test-pull-request/20187/

@mhdawson
Copy link
Member Author

Resume build to re-run for PPC le. Looks like there might have been some conflict with something else running? https://ci.nodejs.org/job/node-test-pull-request/20193/

@mhdawson
Copy link
Member Author

Ok ci green landing.

@mhdawson
Copy link
Member Author

Landed as ed0da63

@mhdawson mhdawson closed this Jan 18, 2019
mhdawson added a commit that referenced this pull request Jan 18, 2019
@mhdawson
test: improve code coverage for i18n
ed0da63 
Coverage report for src/node_i18n.cc shows that the
Has() method is not covered. This test adds coverage
for that method.

PR-URL: #25428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 23, 2019
@mhdawson @addaleax
test: improve code coverage for i18n
2112b70 
Coverage report for src/node_i18n.cc shows that the
Has() method is not covered. This test adds coverage
for that method.

PR-URL: #25428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@mhdawson @BethGriggs
test: improve code coverage for i18n
46ddcab 
Coverage report for src/node_i18n.cc shows that the
Has() method is not covered. This test adds coverage
for that method.

PR-URL: #25428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@mhdawson @BethGriggs
test: improve code coverage for i18n
f5d1859 
Coverage report for src/node_i18n.cc shows that the
Has() method is not covered. This test adds coverage
for that method.

PR-URL: #25428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@mhdawson @MylesBorins
test: improve code coverage for i18n
6b6c628 
Coverage report for src/node_i18n.cc shows that the
Has() method is not covered. This test adds coverage
for that method.

PR-URL: #25428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@mhdawson mhdawson deleted the coverage-i18n branch September 30, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
coverage Issues and PRs related to native coverage support. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mhdawson @nodejs-github-bot @addaleax @benjamingr @lpinca @cjihrig