build,test: fail coverage
target if tests fail
#25432
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fix for #24966
Make the
coverage-test
target fail if running the tests fail. This way we get early warning that something is borked and we don't publish spurious results./CC @nodejs/build-files @nodejs/benchmarking @nodejs/testing
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes