Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: register the inspector async hooks in bootstrap/node.js #25443

Closed
wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

So it's easier to tell the side effects of this setup.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

So it's easier to tell the side effects of this setup.
@joyeecheung
Copy link
Member Author

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2019
@addaleax addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Jan 14, 2019
@addaleax
Copy link
Member

@danbev
Copy link
Contributor

danbev commented Jan 15, 2019

Re-run of failing node-test-commit-arm
Re-run of failing node-test-commit-windows-fanned

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 16, 2019

@joyeecheung
Copy link
Member Author

Landed in 6b2af91

joyeecheung added a commit that referenced this pull request Jan 16, 2019
So it's easier to tell the side effects of this setup.

PR-URL: #25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jan 16, 2019
So it's easier to tell the side effects of this setup.

PR-URL: #25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
So it's easier to tell the side effects of this setup.

PR-URL: nodejs#25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
So it's easier to tell the side effects of this setup.

PR-URL: nodejs#25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants