util: fix iterable types with special prototype #25457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BridgeAR sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
the
util
|
@nodejs/util PTAL |
devsnek
reviewed
Jan 15, 2019
The fallback should only be taken for a null prototype. If an iterable data type (e.g., Array) has a prototype without `Symbol.iterator`, just try the best to visualize it as object. Fixes: nodejs#25451
BridgeAR
force-pushed
the
fix-inspect-clazz-issue
branch
from
9876622
to
e00c69c
Compare
devsnek
approved these changes
Jan 17, 2019
BridgeAR
added
the
author ready
antsmartian
approved these changes
Jan 17, 2019
jasnell
approved these changes
Jan 17, 2019
danbev
pushed a commit
that referenced
this pull request
Jan 18, 2019
The fallback should only be taken for a null prototype. If an iterable data type (e.g., Array) has a prototype without `Symbol.iterator`, just try the best to visualize it as object. PR-URL: #25457 Fixes: #25451 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 23, 2019
The fallback should only be taken for a null prototype. If an iterable data type (e.g., Array) has a prototype without `Symbol.iterator`, just try the best to visualize it as object. PR-URL: #25457 Fixes: #25451 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback should only be taken for a null prototype. If an
iterable data type (e.g., Array) has a prototype without
Symbol.iterator, just try the best to visualize it as object.Fixes: #25451
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes