Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add metadata about ecdh curve options #25502

Closed
wants to merge 1 commit into from
Closed

doc: add metadata about ecdh curve options #25502

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

  • DEFAULT_ECDH_CURVE default changed to 'auto' for 10.0.0
  • ecdhCurve parameter allowed multiple values and 'auto' from 9.0.0
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@sam-github sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Jan 14, 2019
lpinca
lpinca reviewed Jan 14, 2019
View reviewed changes
doc/api/tls.md Outdated Show resolved Hide resolved
@sam-github
doc: add metadata about ecdh curve options
91d2090 
- DEFAULT_ECDH_CURVE default changed to 'auto' for 10.0.0
- ecdhCurve parameter allowed multiple values and 'auto' from 9.0.0
@Trott
Copy link
Member

Trott commented Jan 15, 2019

Most recent linter failure was some untracked git files from a previous CI run. I manually cleared them. A re-run should work. Looks like CI was stopped here for other reasons though so I won't restart it.

@Trott
Copy link
Member

Trott commented Jan 15, 2019

Oh, wait, it's a docs-only PR. I'm totally going to re-run it.

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2253/

This was referenced Jan 16, 2019
Closed
Closed
@Trott
Copy link
Member

Trott commented Jan 17, 2019 •
edited by danbev
Loading

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2273/ ✔️

@danbev
Copy link
Contributor

danbev commented Jan 17, 2019

Landed in 870186d.

@danbev danbev closed this Jan 17, 2019
danbev pushed a commit that referenced this pull request Jan 17, 2019
@sam-github @danbev
doc: add metadata about ecdh curve options
870186d 
- DEFAULT_ECDH_CURVE default changed to 'auto' for 10.0.0
- ecdhCurve parameter allowed multiple values and 'auto' from 9.0.0

PR-URL: #25502
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Jan 23, 2019
@sam-github @addaleax
doc: add metadata about ecdh curve options
26c5bd8 
- DEFAULT_ECDH_CURVE default changed to 'auto' for 10.0.0
- ecdhCurve parameter allowed multiple values and 'auto' from 9.0.0

PR-URL: #25502
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
@sam-github sam-github deleted the add-ecdh-curve-metadata branch January 29, 2019 21:51
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@sam-github @BethGriggs
doc: add metadata about ecdh curve options
814f261 
- DEFAULT_ECDH_CURVE default changed to 'auto' for 10.0.0
- ecdhCurve parameter allowed multiple values and 'auto' from 9.0.0

PR-URL: #25502
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@sam-github @BethGriggs
doc: add metadata about ecdh curve options
a61e260 
- DEFAULT_ECDH_CURVE default changed to 'auto' for 10.0.0
- ecdhCurve parameter allowed multiple values and 'auto' from 9.0.0

PR-URL: #25502
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@sam-github @MylesBorins
doc: add metadata about ecdh curve options
5631d7a 
- DEFAULT_ECDH_CURVE default changed to 'auto' for 10.0.0
- ecdhCurve parameter allowed multiple values and 'auto' from 9.0.0

PR-URL: #25502
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sam-github @nodejs-github-bot @Trott @danbev @bnoordhuis @jasnell @lpinca @cjihrig @BridgeAR