Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade to libuv 1.25.0 #25571

Merged
merged 1 commit into from
Jan 21, 2019
Merged

deps: upgrade to libuv 1.25.0 #25571

merged 1 commit into from
Jan 21, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 18, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2290/pipeline

@nodejs-github-bot nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Jan 18, 2019
@targos
Copy link
Member

targos commented Jan 18, 2019

Are there notable changes?

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 19, 2019

Are there notable changes?

The full changelog for the release is available here. Changes that might be notable to Node:

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 19, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/20209/

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 21, 2019

cc: @nodejs/libuv

@cjihrig
deps: upgrade to libuv 1.25.0
f698386 
PR-URL: nodejs#25571
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@cjihrig cjihrig merged commit f698386 into nodejs:master Jan 21, 2019
@cjihrig cjihrig deleted the libuv branch January 21, 2019 15:30
targos pushed a commit that referenced this pull request Jan 24, 2019
@cjihrig @targos
deps: upgrade to libuv 1.25.0
c0859d7 
PR-URL: #25571
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request May 2, 2019
Closed
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
deps: upgrade to libuv 1.25.0
45a47b0 
PR-URL: nodejs#25571
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
deps: upgrade to libuv 1.25.0
e6275f9 
Backport-PR-URL: #27728
PR-URL: #25571
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 16, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santigimeno santigimeno santigimeno approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @targos @addaleax @santigimeno