Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor policy code for readability #25629

Closed
wants to merge 1 commit into from
Closed

lib: refactor policy code for readability #25629

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Simplify a few particularly quirky bits of code, and add
whitespace for readability.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
lib: refactor policy code for readability
fe386ee 
Simplify a few particularly quirky bits of code, and add
whitespace for readability.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2335/pipeline

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Jan 21, 2019
lundibundi
lundibundi approved these changes Jan 21, 2019
View reviewed changes
lib/internal/policy/sri.js
}
} = require('buffer');

const BufferFrom = require('buffer').Buffer.from;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aw i liked this before :(

@antsmartian
Copy link
Contributor

CI : https://ci.nodejs.org/job/node-test-pull-request/20252/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2019
@addaleax
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20305/

@danbev
Copy link
Contributor

danbev commented Jan 25, 2019

Landed in 0f5c14c.

@danbev danbev closed this Jan 25, 2019
addaleax added a commit that referenced this pull request Jan 28, 2019
@addaleax
lib: refactor policy code for readability
0640b09 
Simplify a few particularly quirky bits of code, and add
whitespace for readability.

PR-URL: #25629
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@targos targos mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundibundi lundibundi lundibundi approved these changes

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@antsmartian antsmartian antsmartian approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @nodejs-github-bot @antsmartian @danbev @thefourtheye @cjihrig @devsnek @lundibundi