Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix keyObject.symmetricSize to be keyObject.symmetricKeySize #25670

Closed
wants to merge 1 commit into from
Closed

doc: fix keyObject.symmetricSize to be keyObject.symmetricKeySize #25670

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Jan 23, 2019

This PR fixes wrong property in crypto documentation for an API added in 11.6.0

cc @tniessen

k = crypto.createSecretKey(Buffer.from('foo'))
// SecretKeyObject { [Symbol(kKeyType)]: 'secret' }
k.symmetricSize
// undefined
k.symmetricKeySize
// 3
Checklist

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Jan 23, 2019
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 23, 2019
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2395/

@vsemozhetbyt
Copy link
Contributor

Landed in 71b00f0
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Jan 26, 2019
@panva @vsemozhetbyt
doc: fix keyObject.symmetricSize to be keyObject.symmetricKeySize
71b00f0 
PR-URL: #25670
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@panva @addaleax
doc: fix keyObject.symmetricSize to be keyObject.symmetricKeySize
3c5a7a2 
PR-URL: #25670
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@targos targos mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@antsmartian antsmartian antsmartian approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@panva @vsemozhetbyt @addaleax @antsmartian @cjihrig @tniessen @nodejs-github-bot