Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix metadata for v11.8.0 doc changes #25709

Closed
wants to merge 1 commit into from
Closed

doc: fix metadata for v11.8.0 doc changes #25709

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

Refs: 641de82

cc @MylesBorins

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2389/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 25, 2019
@richardlau richardlau mentioned this pull request Jan 25, 2019
Closed
@richardlau
Copy link
Member Author

richardlau commented Jan 25, 2019 •
edited
Loading

See #25705 (comment). I'll leave it to @MylesBorins to decide if this PR should be folded into #25705.

@addaleax
Copy link
Member

Please 👍 this comment to approve fast-tracking

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 25, 2019
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2019
MylesBorins
MylesBorins approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Jan 26, 2019

Landed in bbb2134

@Trott Trott closed this Jan 26, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 26, 2019
@richardlau @Trott
doc: fix metadata for v11.8.0 doc changes
bbb2134 
Refs: nodejs@641de82

PR-URL: nodejs#25709
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@richardlau @addaleax
doc: fix metadata for v11.8.0 doc changes
1aa7f4d 
Refs: 641de82

PR-URL: #25709
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@richardlau @nodejs-github-bot @addaleax @Trott @MylesBorins @lpinca @cjihrig @vsemozhetbyt