Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove pummel/test-exec #25722

Closed
wants to merge 1 commit into from
Closed

test: remove pummel/test-exec #25722

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 26, 2019

Remove redundant test/pummel/test-exec.js.

Refs: #25686 (review)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: remove pummel/test-exec
f199be1 
Remove redundant test/pummel/test-exec.js.

Refs: nodejs#25686 (review)
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2399/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 26, 2019
@Trott
Copy link
Member Author

Trott commented Jan 27, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20344/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2019
@Trott
Copy link
Member Author

Trott commented Jan 28, 2019

Landed in 953dae1

@Trott Trott closed this Jan 28, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 28, 2019
@Trott
test: remove pummel/test-exec
953dae1 
Remove redundant test/pummel/test-exec.js.

Refs: nodejs#25686 (review)

PR-URL: nodejs#25722
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott mentioned this pull request Jan 28, 2019
Closed
2 tasks
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@Trott @addaleax
test: remove pummel/test-exec
c7dbb72 
Remove redundant test/pummel/test-exec.js.

Refs: #25686 (review)

PR-URL: #25722
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jan 29, 2019
Merged
@Trott Trott deleted the remove-exec-test branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@Fishrock123 Fishrock123 Awaiting requested review from Fishrock123

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @jasnell @addaleax @lpinca @cjihrig @BethGriggs