src: remove unused field in node_http2.h #25727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gengjiawen <technicalcute@gmail.com>
nodejs-github-bot
added
c++
addaleax
approved these changes
Jan 26, 2019
cjihrig
approved these changes
Jan 26, 2019
jasnell
approved these changes
Jan 28, 2019
addaleax
added
the
author ready
|
Landed in d4d76b6. |
danbev
pushed a commit
that referenced
this pull request
Jan 29, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25727 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 29, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25727 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25727 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25727 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25727 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field is no longer needed after this refactor: 0625627.
make -j4 test(UNIX), orvcbuild test(Windows) passes