Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: make trailing commas consistent in .eslintrc #25739

Closed
wants to merge 1 commit into from
Closed

tools: make trailing commas consistent in .eslintrc #25739

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 27, 2019 •
edited
Loading

.eslintrc has lots of trailing commas and lots of places where there
aren't trailing commas. Use trailing commas throughout the files for
consistency.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
tools: make trailing commas consistent in .eslintrc
768cc1b 
.eslintrc has lots of trailing commas and lots of places where there
aren't trailing commas. Use trailing commas throughout the files for
consistency.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2405/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 27, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2019
devsnek
devsnek approved these changes Jan 27, 2019
View reviewed changes
Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if only we could do this to the whole codebase 😢

@Trott
Copy link
Member Author

Trott commented Jan 27, 2019

if only we could do this to the whole codebase 😢

soon

@addaleax
Copy link
Member

Landed in 1a37fd6

@addaleax addaleax closed this Jan 29, 2019
pull bot pushed a commit to zys-contrib/node that referenced this pull request Jan 29, 2019
@Trott @addaleax
tools: make trailing commas consistent in .eslintrc
1a37fd6 
.eslintrc has lots of trailing commas and lots of places where there
aren't trailing commas. Use trailing commas throughout the files for
consistency.

PR-URL: nodejs#25739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
@Trott @targos
tools: make trailing commas consistent in .eslintrc
8032969 
.eslintrc has lots of trailing commas and lots of places where there
aren't trailing commas. Use trailing commas throughout the files for
consistency.

PR-URL: #25739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Jan 29, 2019
Merged
@Trott Trott deleted the dangling-consistency branch January 13, 2022 22:51
@RaisinTen RaisinTen mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@devsnek devsnek devsnek approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @addaleax @lpinca @targos @devsnek @vsemozhetbyt