deps: update llhttp to 1.1.1 #25753
Closed
deps: update llhttp to 1.1.1 #25753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nodejs/http |
addaleax
approved these changes
Jan 28, 2019
cjihrig
approved these changes
Jan 28, 2019
| * | ||
| * NOTE: if this function ever returns a non-pause type error, it will continue | ||
| * to return the same error upon each successive call up until `llhttp_init()` | ||
| * call. |
There was a problem hiding this comment.
Good catch! This could be fixed in the next release. Would you be interested in submitting a PR: https://github.com/nodejs/llhttp/blob/master/src/native/api.h#L68 ?
There was a problem hiding this comment.
@indutny I tried to submit a quick grammar fix through the GitHub UI and accidentally committed it directly (I thought it was still under your account, not the Node.js one): nodejs/llhttp@4ed1a54
Happy to back it out if it's a problem.
|
Landed in 8855d1d. |
lpinca
pushed a commit
that referenced
this pull request
Feb 9, 2019
PR-URL: #25753 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 10, 2019
PR-URL: #25753 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes