report: split up osVersion and machine values #25755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
gireeshpunathil
approved these changes
Jan 28, 2019
addaleax
approved these changes
Jan 28, 2019
Yes, I'd like to do that. There are some differences to reconcile, and it would be nice to use it for Windows as well. Definitely something to do before it graduates from experimental, or not at all IMO. |
jasnell
approved these changes
Jan 29, 2019
|
CI: https://ci.nodejs.org/job/node-test-commit/25418/ The linter failed for some reason. Reran it with no changes and it passed: https://ci.nodejs.org/job/node-test-linter/25296/ EDIT: All green CI: https://ci.nodejs.org/job/node-test-commit/25464/ |
richardlau
approved these changes
Jan 30, 2019
Prior to this commit, on non-Windows platforms, the "osVersion" value was prepended to the "machine" value. PR-URL: nodejs#25755 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 30, 2019
Prior to this commit, on non-Windows platforms, the "osVersion" value was prepended to the "machine" value. PR-URL: #25755 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
3 tasks
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Feb 2, 2019
PR-URL: nodejs#25855 Refs: nodejs#25755 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, on non-Windows platforms, the
"osVersion"value was prepended to the"machine"value.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes