Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix indentation in a few node_http2 enums #25761

Closed
wants to merge 1 commit into from
Closed

src: fix indentation in a few node_http2 enums #25761

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jan 28, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2418/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Jan 28, 2019
@danbev
Copy link
Contributor Author

danbev commented Jan 28, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20373/

@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2019
@addaleax
Copy link
Member

Landed in 756b0ac

@addaleax addaleax closed this Jan 30, 2019
pull bot pushed a commit to shakir-abdo/node that referenced this pull request Jan 30, 2019
@danbev @addaleax
src: fix indentation in a few node_http2 enums
756b0ac 
PR-URL: nodejs#25761
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jan 30, 2019
@danbev @addaleax
src: fix indentation in a few node_http2 enums
35454e0 
PR-URL: #25761
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danbev danbev deleted the http2-enum-indentation branch January 31, 2019 03:31
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @nodejs-github-bot @addaleax @jasnell @lpinca @cjihrig @richardlau