-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update prerequisites on progress towards Python 3 #25766
Conversation
As recommended at nodejs#25759 (comment) * Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan * Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update * Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus
@nodejs/build @nodejs/documentation |
Co-Authored-By: cclauss <cclauss@me.com>
@nodejs/python |
LGTM as a semver-major move for node12 |
@nodejs/tsc |
This is a FYI doc-only change. Why is this semver-major? |
I think that a formal change in supported toolchains (i.e. no longer supporting Python2.6) should be semver-major. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. I missed the 2.6 drop the first time around. Sorry about that.
LGTM.
FWIW, some end users do compile their own binary, and some users are downstream consumers in some way (embedders / tinkerers), so in that sense a change in the toolchain could break their usage. |
Even though this is going in as |
Landed in bb564a3 |
As recommended at #25759 (comment) * Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan * Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update * Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus PR-URL: #25766 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
As recommended at #25759 (comment)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes