-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: find Python 3 or Python 2 in configure #25878
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,34 @@ | ||
#!/bin/sh | ||
|
||
# Locate python2 interpreter and re-execute the script. Note that the | ||
# mix of single and double quotes is intentional, as is the fact that | ||
# the ] goes on a new line. | ||
# Locate an acceptable python interpreter and then re-execute the script. | ||
# Note that the mix of single and double quotes is intentional, | ||
# as is the fact that the ] goes on a new line. | ||
# When a 'which' call is made for a specific version of Python on Travis CI, | ||
# pyenv will alert which shims are available and then will fail the build. | ||
_=[ 'exec' '/bin/sh' '-c' ''' | ||
test ${TRAVIS} && exec python "$0" "$@" # workaround for pyenv on Travis CI | ||
which python2.7 >/dev/null && exec python2.7 "$0" "$@" | ||
which python2 >/dev/null && exec python2 "$0" "$@" | ||
which python3.7 >/dev/null && exec python3.7 "$0" "$@" | ||
which python3.6 >/dev/null && exec python3.6 "$0" "$@" | ||
which python3.5 >/dev/null && exec python3.5 "$0" "$@" | ||
exec python "$0" "$@" | ||
''' "$0" "$@" | ||
] | ||
del _ | ||
|
||
import sys | ||
from distutils.spawn import find_executable as which | ||
if sys.version_info[:2] != (2, 7): | ||
sys.stderr.write('Please use Python 2.7') | ||
from distutils.spawn import find_executable | ||
|
||
python2 = which('python2') or which('python2.7') | ||
|
||
if python2: | ||
sys.stderr.write(':\n\n') | ||
sys.stderr.write(' ' + python2 + ' ' + ' '.join(sys.argv)) | ||
|
||
sys.stderr.write('\n') | ||
print('Node configure: Found Python {0}.{1}.{2}...'.format(*sys.version_info)) | ||
acceptable_pythons = ((2, 7), (3, 7), (3, 6), (3, 5)) | ||
if sys.version_info[:2] in acceptable_pythons: | ||
import configure | ||
else: | ||
python_cmds = ['python{0}.{1}'.format(*vers) for vers in acceptable_pythons] | ||
sys.stderr.write('Please use {0}.\n'.format(' or '.join(python_cmds))) | ||
for python_cmd in python_cmds: | ||
python_cmd_path = find_executable(python_cmd) | ||
if python_cmd_path and 'pyenv/shims' not in python_cmd_path: | ||
sys.stderr.write('\t{0} {1}\n'.format(python_cmd_path, | ||
' '.join(sys.argv[:1]))) | ||
sys.exit(1) | ||
cclauss marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
import configure |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this comment be more informative? I think it should be
But I might misunderstand its purpose.