Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: split ownsProcessState off isMainThread #25881

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 1, 2019

Embedders may want to control whether a Node.js instance
controls the current process, similar to what we currently
have with Workers.

Previously, the isMainThread flag had a bit of a double usage,
both for indicating whether we are (not) running a Worker and
whether we can modify per-process state.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 1, 2019
src/env.h Outdated Show resolved Hide resolved
Embedders may want to control whether a Node.js instance
controls the current process, similar to what we currently
have with `Worker`s.

Previously, the `isMainThread` flag had a bit of a double usage,
both for indicating whether we are (not) running a Worker and
whether we can modify per-process state.
@addaleax
Copy link
Member Author

addaleax commented Feb 4, 2019

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2019
@addaleax
Copy link
Member Author

addaleax commented Feb 5, 2019

@addaleax addaleax changed the title src: split controlsProcess off isMainThread src: split ownsProcessState off isMainThread Feb 5, 2019
@addaleax
Copy link
Member Author

addaleax commented Feb 5, 2019

Landed in 39eca84

@addaleax addaleax closed this Feb 5, 2019
@addaleax addaleax deleted the split-is-main-thread branch February 5, 2019 20:58
addaleax added a commit that referenced this pull request Feb 5, 2019
Embedders may want to control whether a Node.js instance
controls the current process, similar to what we currently
have with `Worker`s.

Previously, the `isMainThread` flag had a bit of a double usage,
both for indicating whether we are (not) running a Worker and
whether we can modify per-process state.

PR-URL: #25881
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member Author

addaleax commented Feb 6, 2019

This depends on earlier PRs in order to be backported (and possibly apply cleanly).

targos pushed a commit that referenced this pull request Feb 10, 2019
Embedders may want to control whether a Node.js instance
controls the current process, similar to what we currently
have with `Worker`s.

Previously, the `isMainThread` flag had a bit of a double usage,
both for indicating whether we are (not) running a Worker and
whether we can modify per-process state.

PR-URL: #25881
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants