Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: remove unreachable return #25883

Closed
wants to merge 1 commit into from
Closed

benchmark: remove unreachable return #25883

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Feb 2, 2019 •
edited
Loading

Remove the unreachable return since this.abort has process.exit(1).

node/benchmark/_cli.js

Lines 74 to 84 in 0f8e8f7

this.abort(usage);
return;
}
}
}
module.exports = CLI;
CLI.prototype.abort = function(msg) {
console.error(msg);
process.exit(1);
};

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Feb 2, 2019
@ZYSzys ZYSzys changed the title benchmark: remove useless return in _cli.js benchmark: remove unreachable return Feb 2, 2019
@danbev
Copy link
Contributor

danbev commented Feb 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20633/

@danbev
Copy link
Contributor

danbev commented Feb 7, 2019

Landed in b4e670d.

@danbev danbev closed this Feb 7, 2019
danbev pushed a commit that referenced this pull request Feb 7, 2019
@ZYSzys @danbev
benchmark: remove unreachable return
b4e670d 
PR-URL: #25883
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Feb 7, 2019
@ZYSzys @addaleax
benchmark: remove unreachable return
2b1f881 
PR-URL: #25883
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@ZYSzys ZYSzys deleted the benchmark-cli branch February 9, 2019 15:23
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZYSzys @danbev @addaleax @richardlau @nodejs-github-bot