src: fix data type in node_crypto.cc #25889
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gengjiawen <technicalcute@gmail.com>
nodejs-github-bot
added
c++
addaleax
approved these changes
Feb 2, 2019
Contributor
danbev
approved these changes
Feb 5, 2019
cjihrig
approved these changes
Feb 5, 2019
jasnell
approved these changes
Feb 5, 2019
Contributor
|
Landed in d3ea639. |
dnalborczyk
pushed a commit
to dnalborczyk/node
that referenced
this pull request
Feb 6, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: nodejs#25889 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25889 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passes