-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: improve prerequisites for test-all-suites #25892
Conversation
The prerequisistes for test-all-suites were running some tests themselves. When one of those tests failed during a coverage run, it resulted in artificially low coverage. Fix the prerequisites to only build stuff, not test.
@nodejs/build-files |
I'd like to fast-track this so we can use it for nodejs/build#1676 and get that closed out. Please 👍here to fast-track. |
Testing a coverage job with this too: https://ci.nodejs.org/view/All/job/node-test-commit-linux-coverage-daily/28/ EDIT: Results seem reasonable: 06:30:40 Javascript coverage %: 95.47%
06:30:40 C++ coverage %: 90.3% |
Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/20545/ |
Something odd is up with the resume build. Only Windows left to pass, so here's Windows CI: |
Landed in 4deb23a |
The prerequisistes for test-all-suites were running some tests themselves. When one of those tests failed during a coverage run, it resulted in artificially low coverage. Fix the prerequisites to only build stuff, not test. PR-URL: nodejs#25892 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
The prerequisistes for test-all-suites were running some tests themselves. When one of those tests failed during a coverage run, it resulted in artificially low coverage. Fix the prerequisites to only build stuff, not test. PR-URL: #25892 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
The prerequisistes for test-all-suites were running some tests
themselves. When one of those tests failed during a coverage run, it
resulted in artificially low coverage. Fix the prerequisites to only
build stuff, not test.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes