Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: print libuv handle addresses as hex #25910

Merged
merged 1 commit into from
Feb 5, 2019
Merged

report: print libuv handle addresses as hex #25910

merged 1 commit into from
Feb 5, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 3, 2019

hex is more common than decimal when discussing addresses.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2502/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 3, 2019
@addaleax addaleax added the report Issues and PRs related to process.report. label Feb 3, 2019
@addaleax addaleax mentioned this pull request Feb 3, 2019
Closed
3 tasks
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 5, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/20575/

@cjihrig
report: print libuv handle addresses as hex
2ed556c 
PR-URL: nodejs#25910
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 2ed556c into nodejs:master Feb 5, 2019
@cjihrig cjihrig deleted the hex branch February 5, 2019 17:11
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@cjihrig @addaleax
report: print libuv handle addresses as hex
30a4e89 
PR-URL: #25910
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @bnoordhuis @jasnell @addaleax @richardlau @MylesBorins