-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add a sentence about REPLACEME in code changes #25961
Conversation
When adding to the REPL API recently, I was unsure what to put as a version number for the new method I added. This change adds a reference to `releases.md` where the use of `REPLACEME` is discussed.
This is a simple doc change. Any reason not to fast-track it? |
@@ -116,7 +116,9 @@ time to ensure that the changes follow the Node.js code style guide. | |||
Any documentation you write (including code comments and API documentation) | |||
should follow the [Style Guide](../../STYLE_GUIDE.md). Code samples included | |||
in the API docs will also be checked when running `make lint` (or | |||
`vcbuild.bat lint` on Windows). | |||
`vcbuild.bat lint` on Windows). If you are adding to or deprecating the API, | |||
be sure to use `REPLACEME` for the version numbers as specified in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be sure to use `REPLACEME` for the version numbers as specified in | |
use `REPLACEME` for the version number as specified in |
To be honest, this sentence seems to come out of nowhere. There's no context explaining the YAML stuff etc. This might be more confusing than enlightening if a new person is reading it and doesn't already know about the YAML stuff. That said, having it documented is an improvement over not having it documented, so I'm totally OK with this landing as-is. But if there's a place to move this where it would have more context, that would be good. (Again, though, someone else can do that in a subsequent PR if the only goal here is to have it documented somewhere that a contributor might find it.) An idea: Would it make sense to instead put this as a YAML comment in every |
@@ -116,7 +116,9 @@ time to ensure that the changes follow the Node.js code style guide. | |||
Any documentation you write (including code comments and API documentation) | |||
should follow the [Style Guide](../../STYLE_GUIDE.md). Code samples included | |||
in the API docs will also be checked when running `make lint` (or | |||
`vcbuild.bat lint` on Windows). | |||
`vcbuild.bat lint` on Windows). If you are adding to or deprecating the API, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`vcbuild.bat lint` on Windows). If you are adding to or deprecating the API, | |
`vcbuild.bat lint` on Windows). If you are adding to or deprecating an API, |
Maybe the only context that needs to be added is just a mention that this is referring to the YAML metadata? If you are adding to or deprecating an API, use `REPLACEME`
for the version number in the documentation YAML metadata. Probably no need to link to |
@Trott I don't think it would be that hard to add it as a comment in the YAML itself. E.g. sed -i 's/^<!-- YAML*$/<!-- YAML\n# When adding to or deprecating an API, use \'REPLACEME\' for the version number/' doc/api/*.md |
My only concern here is whether the |
I think this is fast-track-able in its current form. Please 👍 here to approve fast-tracking. |
@Trott I inadvertently pushed this branch to |
That seems like it would be fine to me. |
Landed in 93a57c3. |
When adding to the REPL API recently, I was unsure what to put as a version number for the new method I added. This change adds a reference to `releases.md` where the use of `REPLACEME` is discussed. PR-URL: #25961 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
When adding to the REPL API recently, I was unsure what to put as a version number for the new method I added. This change adds a reference to `releases.md` where the use of `REPLACEME` is discussed. PR-URL: #25961 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
When adding to the REPL API recently, I was unsure what to put as a
version number for the new method I added. This change adds a reference
to
releases.md
where the use ofREPLACEME
is discussed.Checklist