Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: refactor and rename setDiagnosticReportOptions() #25990

Merged
merged 2 commits into from
Feb 9, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 7, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Feb 7, 2019
@richardlau richardlau added the report Issues and PRs related to process.report. label Feb 7, 2019
PR-URL: nodejs#25990
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
setDiagnosticReportOptions() is a method on process.report,
making the "DiagnosticReport" part redundant. Rename the
function to setOptions().

PR-URL: nodejs#25990
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2019

@cjihrig cjihrig merged commit e154176 into nodejs:master Feb 9, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2019

Landed in 46c16b3 and e154176.

@cjihrig cjihrig deleted the report-validation branch February 9, 2019 22:12
targos pushed a commit that referenced this pull request Feb 10, 2019
PR-URL: #25990
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Feb 10, 2019
setDiagnosticReportOptions() is a method on process.report,
making the "DiagnosticReport" part redundant. Rename the
function to setOptions().

PR-URL: #25990
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Issues and PRs related to the process subsystem. report Issues and PRs related to process.report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants