New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: finalize during second-pass callback #25992

Closed

gabrielschulhof wants to merge 1 commit into nodejs:master from gabrielschulhof:25927-finalize-during-second-pass-callback

Commits on Feb 7, 2019

n-api: finalize during second-pass callback

Calling into the engine from a weak callback is unsafe, however, the
engine offers a way to attach a second-pass weak callback which gets
called when it is safe to call into JavaScript. This moves the point
at which the N-API finalize callback gets called to this latter point.

Fixes: nodejs#25927

Gabriel Schulhof committed Feb 7, 2019