src: remove process.binding('config').debugOptions
#25999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
joyeecheung
force-pushed
the
debug-options
branch
from
59a2b71
to
f4e4da9
Compare
`process.binding('config').debugOptions`, which contains the initial
values of parsed debugger-related CLI options, has been used for
internal testing. This patch removes them and uses `internal/options`
to query the values in the tests instead.
joyeecheung
force-pushed
the
debug-options
branch
from
f4e4da9
to
26d3abd
Compare
|
Ping @nodejs/process @addaleax can I have some review please? |
danbev
approved these changes
Feb 18, 2019
addaleax
approved these changes
Feb 18, 2019
|
CI is green … Should this be labelled |
|
@addaleax We can label it don't land on v11 on the safe side, although the properties exposed here are not even really useful for non-test use cases as they only capture the parsed CLI options, and are not in sync with the actual state of the process. e.g. if someone wants to know about the port they are more likely to use the documented |
|
Fresh CI: https://ci.nodejs.org/job/node-test-pull-request/20866/ (✔️) |
jasnell
approved these changes
Feb 18, 2019
|
Landed in b200a46. |
pull bot
pushed a commit
to shakir-abdo/node
that referenced
this pull request
Feb 19, 2019
`process.binding('config').debugOptions`, which contains the initial
values of parsed debugger-related CLI options, has been used for
internal testing. This patch removes them and uses `internal/options`
to query the values in the tests instead.
PR-URL: nodejs#25999
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.binding('config').debugOptions, which contains the initialvalues of parsed debugger-related CLI options, has been used for
internal testing. This patch removes them and uses
internal/optionsto query the values in the tests instead.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes