process: group main thread execution preparation code #26000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
joyeecheung
force-pushed
the
pre-execute
branch
from
d6d1c33
to
f5ca281
Compare
richardlau
approved these changes
Feb 8, 2019
jdalton
reviewed
Feb 8, 2019
| @@ -0,0 +1,34 @@ | |||
| 'use strict'; | |||
This patch groups the preparation of main thread execution into `prepareMainThreadExecution()` and removes the cluster IPC setup in worker thread bootstrap since clusters do not use worker threads for its implementation and it's unlikely to change.
And make sure that `process.argv` from the preloaded modules is the same as the one in the main module. Refs: nodejs#25967
joyeecheung
force-pushed
the
pre-execute
branch
from
f5ca281
to
5ea16b0
Compare
|
Skip the test in workers since we can't chdir there. CI: https://ci.nodejs.org/job/node-test-pull-request/20699/ |
You can set the |
JungMinu
approved these changes
Feb 10, 2019
|
Landed in 70f4f08...69714ab |
joyeecheung
added a commit
that referenced
this pull request
Feb 10, 2019
This patch groups the preparation of main thread execution into `prepareMainThreadExecution()` and removes the cluster IPC setup in worker thread bootstrap since clusters do not use worker threads for its implementation and it's unlikely to change. PR-URL: #26000 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
targos
pushed a commit
that referenced
this pull request
Feb 10, 2019
This patch groups the preparation of main thread execution into `prepareMainThreadExecution()` and removes the cluster IPC setup in worker thread bootstrap since clusters do not use worker threads for its implementation and it's unlikely to change. PR-URL: #26000 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch groups the preparation of main thread execution into
prepareMainThreadExecution()and removes the cluster IPCsetup in worker thread bootstrap since clusters do not use
worker threads for its implementation and it's unlikely to change.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes