-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report: make more items programmatically accessible #26019
Conversation
Prefer structured output over stringified information for libuv handles and the native stack trace.
CI: https://ci.nodejs.org/job/node-test-pull-request/20700/ (:heavy_check_mark:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Side note - keeping the example report in the docs up to date is becoming a bit of a pain 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed in 2c84f6e |
Prefer structured output over stringified information for libuv handles and the native stack trace. PR-URL: #26019 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Prefer structured output over stringified information for libuv handles and the native stack trace. PR-URL: #26019 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Prefer structured output over stringified information
for libuv handles and the native stack trace.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes