Commits on Feb 10, 2019

1. src: pass cli options to bootstrap/loaders.js lexically …

   Instead of using `internalBinding('config')` which should be used
   to carry information about build-time options, directly pass the
   run-time cli options into bootstrap/loaders.js lexically via
   function arguments.
   
   PR-URL: nodejs#25463
   Reviewed-By: Anna Henningsen <anna@addaleax.net>
   Reviewed-By: Refael Ackermann <refack@gmail.com>

   

   joyeecheung authored and ZYSzys committed Feb 10, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for d1e0955
   • Browse repository at this point

   Copy the full SHA

   d1e0955 View commit details

   Browse the repository at this point in the history

2. src: remove unused internalBinding('config') properties …

   Remove the following properties:
   
   - `preserveSymlinks`
   - `preserveSymlinksMain`
   - `experimentalModules`
   - `userLoader`
   - `experimentalVMModules`
   - `experimentalREPLAwait`
   - `exposeInternals`
   
   We used to use them to pass cli option values from C++ into
   JS, but now the values are obtained in JS land using
   `require('internal/options').getOptionValue` instead so they
   are unused.
   
   Also removes `test/parallel/test-internal-modules-expose.js`
   which tests `--expose-internals`.
   We already have hundreds of tests depending on `--expose-internals`,
   they are more than enough to test the functionality of the flag.
   
   PR-URL: nodejs#25463
   Reviewed-By: Anna Henningsen <anna@addaleax.net>
   Reviewed-By: Refael Ackermann <refack@gmail.com>

   

   joyeecheung authored and ZYSzys committed Feb 10, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 72d135b
   • Browse repository at this point

   Copy the full SHA

   72d135b View commit details

   Browse the repository at this point in the history