Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: cleanup and document the bootstrap process in bootstrap/node.js #26033

Closed
wants to merge 5 commits into from
Closed

process: cleanup and document the bootstrap process in bootstrap/node.js #26033

wants to merge 5 commits into from

Conversation

joyeecheung
Copy link
Member

lib: move per_context.js under lib/internal/bootstrap

process: document the bootstrap process in node.js

lib: save a copy of Symbol in primordials

process: use primordials in bootstrap/node.js

process: refactor lib/internal/bootstrap/node.js

  • Use deprecate from internal/util instead of from util
  • Split setupGlobalVariables() into setupGlobalProxy() and
    setupBuffer(), and move out manipulation of the process object.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@joyeecheung
lib: move per_context.js under lib/internal/bootstrap
e7950a9
@joyeecheung
process: document the bootstrap process in node.js
9b56d96
@joyeecheung
lib: save a copy of Symbol in primordials
2b70a03
@joyeecheung
process: use primordials in bootstrap/node.js
043b540
@joyeecheung
process: refactor lib/internal/bootstrap/node.js
1672e3b 
- Use `deprecate` from `internal/util` instead of from `util`
- Split `setupGlobalVariables()` into `setupGlobalProxy()` and
  `setupBuffer()`, and move out manipulation of the process object.
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2563/pipeline

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Feb 10, 2019
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20739/

@joyeecheung
Copy link
Member Author

Landed in 771b290...006e78c

joyeecheung added a commit that referenced this pull request Feb 12, 2019
@joyeecheung
lib: move per_context.js under lib/internal/bootstrap
68afae2 
PR-URL: #26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Feb 12, 2019
@joyeecheung
process: document the bootstrap process in node.js
008074f 
PR-URL: #26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Feb 12, 2019
@joyeecheung
lib: save a copy of Symbol in primordials
fda80e3 
PR-URL: #26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Feb 12, 2019
@joyeecheung
process: use primordials in bootstrap/node.js
e5da922 
PR-URL: #26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Feb 12, 2019
@joyeecheung
process: refactor lib/internal/bootstrap/node.js
006e78c 
- Use `deprecate` from `internal/util` instead of from `util`
- Split `setupGlobalVariables()` into `setupGlobalProxy()` and
  `setupBuffer()`, and move out manipulation of the process object.

PR-URL: #26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 13, 2019
@joyeecheung @addaleax
lib: move per_context.js under lib/internal/bootstrap
bd932a3 
PR-URL: #26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 13, 2019
@joyeecheung @addaleax
process: document the bootstrap process in node.js
85bc64a 
PR-URL: #26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 13, 2019
@joyeecheung @addaleax
lib: save a copy of Symbol in primordials
d5f4a1f 
PR-URL: #26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 13, 2019
@joyeecheung @addaleax
process: use primordials in bootstrap/node.js
8d3eb47 
PR-URL: #26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Feb 13, 2019
@joyeecheung @addaleax
process: refactor lib/internal/bootstrap/node.js
7d1a00c 
- Use `deprecate` from `internal/util` instead of from `util`
- Split `setupGlobalVariables()` into `setupGlobalProxy()` and
  `setupBuffer()`, and move out manipulation of the process object.

PR-URL: nodejs#26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Feb 13, 2019
Closed
targos pushed a commit that referenced this pull request Feb 14, 2019
@joyeecheung @targos
process: refactor lib/internal/bootstrap/node.js
9d6291a 
- Use `deprecate` from `internal/util` instead of from `util`
- Split `setupGlobalVariables()` into `setupGlobalProxy()` and
  `setupBuffer()`, and move out manipulation of the process object.

PR-URL: #26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: #26085
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
This was referenced Feb 15, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joyeecheung @nodejs-github-bot @jasnell @addaleax