-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: renamed remote's name. #26050
Closed
thangktran
wants to merge
1
commit into
nodejs:master
from
thangktran:thangktran/fix-pull-request-guide
Closed
doc: renamed remote's name. #26050
thangktran
wants to merge
1
commit into
nodejs:master
from
thangktran:thangktran/fix-pull-request-guide
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroppy
approved these changes
Feb 11, 2019
@thangktran:Please remove '.' at the end of your submit statement and forcely push it, then you can pass CI test :) |
ghost
approved these changes
Feb 12, 2019
To keep consistency through-out the guide. Fixes: nodejs#26045
thangktran
force-pushed
the
thangktran/fix-pull-request-guide
branch
from
February 12, 2019 05:25
6d26d55
to
0f480e1
Compare
Thank you for your input. I've corrected it. |
ckotzbauer
approved these changes
Feb 12, 2019
Trott
approved these changes
Feb 12, 2019
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 12, 2019
antsmartian
approved these changes
Feb 12, 2019
shisama
approved these changes
Feb 12, 2019
Landed in 1c66ad4, thanks for the PR! 🎉 |
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep consistency through-out the guide.
Fixes: #26045
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes